signon.autofillForms.http + contextual warning #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are any of these 3 commits meant to have a (FF52+) at the end? |
|
I'm also OK with committing these now. The v51 is archived, then we start on the next version. It's either that or we create our releases just prior to the next one - which means less time, relevance. Besides, we do add version numbers to prefs. We have tons of time anyway, no need to hurry. But I will still only change the version number, code name, lyric, and date just prior to a release. |
Yes, I forgot to add that. I'll add it.
I only mentioned to wait in case the prefs are backed out in stable for whatever reason. |
Thorin-Oakenpants
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my proposal as a PR, let's have a discussion if necessary and maybe wait with merging this until FF52 stable is released